From bf525d35301dcf0c612598f4394e4357b8378746 Mon Sep 17 00:00:00 2001
From: Thomas Vanbesien <tvanbesi@proton.me>
Date: Tue, 16 Jun 2026 14:56:46 +0200
Subject: fix: make ping exchange follow the protocol specification

---
 src/Xpl2Client.cpp | 18 +++---------------
 src/Xpl2Client.h   |  1 -
 2 files changed, 3 insertions(+), 16 deletions(-)

(limited to 'src')

diff --git a/src/Xpl2Client.cpp b/src/Xpl2Client.cpp
index 2a972e0..102970e 100644
--- a/src/Xpl2Client.cpp
+++ b/src/Xpl2Client.cpp
@@ -679,9 +679,7 @@ Xpl2Client::sendCommand (QTcpSocket *socket, const QByteArray &command,
 void
 Xpl2Client::dispatchCommandMessage (const Xpl2Protocol::ParsedMessage &msg)
 {
-  if (msg.command == "KA_PING")
-    handleKaPing (&m_commandSocket);
-  else if (msg.command == "EV_SHUTTING_DOWN")
+  if (msg.command == "EV_SHUTTING_DOWN")
     emit shuttingDown ();
   else if (msg.command == "GS_JC_VERSION")
     handleGsJcVersion (msg.params);
@@ -695,9 +693,7 @@ Xpl2Client::dispatchCommandMessage (const Xpl2Protocol::ParsedMessage &msg)
 void
 Xpl2Client::dispatchImagingMessage (const Xpl2Protocol::ParsedMessage &msg)
 {
-  if (msg.command == "KA_PING")
-    handleKaPing (&m_imagingSocket);
-  else if (msg.command == "EV_SHUTTING_DOWN")
+  if (msg.command == "EV_SHUTTING_DOWN")
     emit shuttingDown ();
   else if (msg.command == "n")
     {
@@ -725,9 +721,7 @@ Xpl2Client::dispatchImagingMessage (const Xpl2Protocol::ParsedMessage &msg)
 void
 Xpl2Client::dispatchStatusMessage (const Xpl2Protocol::ParsedMessage &msg)
 {
-  if (msg.command == "KA_PING")
-    handleKaPing (&m_statusSocket);
-  else if (msg.command == "EV_SHUTTING_DOWN")
+  if (msg.command == "EV_SHUTTING_DOWN")
     emit shuttingDown ();
   else if (msg.command == "EV_STATUS_MSG_JC")
     handleEvStatusMsgJc (msg.params);
@@ -738,12 +732,6 @@ Xpl2Client::dispatchStatusMessage (const Xpl2Protocol::ParsedMessage &msg)
               msg.command.constData ());
 }
 
-void
-Xpl2Client::handleKaPing (QTcpSocket *socket)
-{
-  sendCommand (socket, "KA_PING", { 1 });
-}
-
 void
 Xpl2Client::handleGsJcVersion (const QVariantList &params)
 {
diff --git a/src/Xpl2Client.h b/src/Xpl2Client.h
index ef29ddb..49fbec5 100644
--- a/src/Xpl2Client.h
+++ b/src/Xpl2Client.h
@@ -306,7 +306,6 @@ private:
   void dispatchCommandMessage (const Xpl2Protocol::ParsedMessage &msg);
   void dispatchImagingMessage (const Xpl2Protocol::ParsedMessage &msg);
   void dispatchStatusMessage (const Xpl2Protocol::ParsedMessage &msg);
-  void handleKaPing (QTcpSocket *socket);
   void handleGsJcVersion (const QVariantList &params);
   void handleGsPhVersion (const QVariantList &params);
   enum class ResponseShape
-- 
cgit v1.3.1