Logs, Comments & General organization on FSE/PPC.

Several improvements.

1 files changed, 11 insertions, 18 deletions

diff --git a/Software/Visual_Studio/PPC/Tango.PPC.Common/MachineUpdate/MachineUpdateManager.cs b/Software/Visual_Studio/PPC/Tango.PPC.Common/MachineUpdate/MachineUpdateManager.cs
index 733574f72..9a12552bc 100644
--- a/Software/Visual_Studio/PPC/Tango.PPC.Common/MachineUpdate/MachineUpdateManager.cs
+++ b/Software/Visual_Studio/PPC/Tango.PPC.Common/MachineUpdate/MachineUpdateManager.cs
@@ -1687,30 +1687,23 @@ namespace Tango.PPC.Common.MachineUpdate
 
         public void OnReceiverDisconnected(ExternalBridgeReceiver receiver)
         {
-
+            //Do nothing.
         }
 
-        [ExternalBridgeRequestHandlerMethod(typeof(GetUpdatesAndPackagesRequest))]
-        public async void OnGetUpdatesAndPackagesRequest(GetUpdatesAndPackagesRequest request, String token, ExternalBridgeReceiver receiver)
+        [ExternalBridgeRequestHandlerMethod(typeof(GetUpdatesAndPackagesRequest), RequestHandlerLoggingMode.LogRequestName)]
+        public async Task OnGetUpdatesAndPackagesRequest(GetUpdatesAndPackagesRequest request, String token, ExternalBridgeReceiver receiver)
         {
-            try
+            using (ObservablesContext db = ObservablesContext.CreateDefault())
             {
-                using (ObservablesContext db = ObservablesContext.CreateDefault())
-                {
-                    var updates = await db.TangoUpdates.OrderByDescending(x => x.StartDate).ToListAsync();
-                    var updatesDTO = updates.Select(x => TangoUpdateDTO.FromObservable(x)).ToList();
-                    var packages = (await _packageRunner.GetPackagesFile()).PackageInstallations;
+                var updates = await db.TangoUpdates.OrderByDescending(x => x.StartDate).ToListAsync();
+                var updatesDTO = updates.Select(x => TangoUpdateDTO.FromObservable(x)).ToList();
+                var packages = (await _packageRunner.GetPackagesFile()).PackageInstallations;
 
-                    var response = new GetUpdatesAndPackagesResponse();
-                    response.Updates.AddRange(updatesDTO);
-                    response.Packages.AddRange(packages);
+                var response = new GetUpdatesAndPackagesResponse();
+                response.Updates.AddRange(updatesDTO);
+                response.Packages.AddRange(packages);
 
-                    await receiver.SendGenericResponse(response, token);
-                }
-            }
-            catch (Exception ex)
-            {
-                await receiver.SendErrorResponse(ex, token);
+                await receiver.SendGenericResponse(response, token);
             }
         }