From bf66536228666d733475f4ccdb248e5cec74c0aa Mon Sep 17 00:00:00 2001
From: Victoria Plitt <Victoria.Plitt@twine-s.com>
Date: Tue, 5 Nov 2019 11:38:50 +0200
Subject: Done

Related Work Items: #1277
---
 .../Modules/Tango.MachineStudio.Developer/Views/MainView.xaml     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views')

diff --git a/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/MainView.xaml b/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/MainView.xaml
index 08ba5b699..abea6aec9 100644
--- a/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/MainView.xaml
+++ b/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/MainView.xaml
@@ -555,15 +555,15 @@
 
                     <Border BorderBrush="{StaticResource GrayBrush280}" BorderThickness="0 1 0 1" Padding="5">
                         <DockPanel>
-                            <StackPanel Orientation="Horizontal" DockPanel.Dock="Left">
-                                <materialDesign:PackIcon Kind="Alert" Width="32" Height="32" VerticalAlignment="Center" />
-                                <TextBlock VerticalAlignment="Center" FontSize="16" FontWeight="SemiBold" Margin="10 0 0 0" FontStyle="Italic">Job Aborted By User</TextBlock>
+                            <StackPanel Orientation="Horizontal" DockPanel.Dock="Left" >
+                                <materialDesign:PackIcon Kind="Alert" Width="32" Height="32" VerticalAlignment="Center" Foreground="#FF494949"/>
+                                <TextBlock VerticalAlignment="Center" Foreground="#FF494949" FontSize="16" FontWeight="SemiBold" Margin="10 0 0 0" FontStyle="Italic">Job Aborted By User</TextBlock>
                             </StackPanel>
 
                             <StackPanel Orientation="Horizontal" DockPanel.Dock="Right" Margin="0 0 10 0">
                                 <Button Padding="0" Height="20" Command="{Binding CloseJobCompletionStatusCommand}" Style="{StaticResource MaterialDesignFlatButton}">
                                     <StackPanel Orientation="Horizontal">
-                                        <materialDesign:PackIcon Foreground="{StaticResource DarkGrayBrush}" VerticalAlignment="Center" Width="20" Height="20" Kind="Close" />
+                                        <materialDesign:PackIcon Foreground="#FF494949" VerticalAlignment="Center" Width="20" Height="20" Kind="Close" />
                                     </StackPanel>
                                 </Button>
                             </StackPanel>
-- 
cgit v1.3.1


From 1c9bea6d04dcfbfd1fbf0e1c437c110bc7dafa3e Mon Sep 17 00:00:00 2001
From: Roy Ben-Shabat <Roy@Twine-s.com>
Date: Thu, 7 Nov 2019 17:39:00 +0200
Subject: Fixed issue with job completion on emulator. Added liquid volumes
 grid full step. Added full step to dispensing calculations. Fixed issue with
 gradient generation progress on MS. Worked on software items doc.

---
 .../ViewModels/MainViewVM.cs                       |  12 +++----
 .../Views/JobView.xaml                             |  35 +++++++++++++++++++++
 .../Twine Software Items (version 1).xlsb.xlsx     | Bin 18776 -> 20410 bytes
 .../Tango.BL/Dispensing/DispensingCalcBase.cs      |  10 ++++++
 .../Tango.BL/Dispensing/DispensingCalcService.cs   |  11 +++++++
 .../Tango.BL/Dispensing/IDispensingCalc.cs         |   7 +++++
 .../Dispensing/TransparentLiquidDispensingCalc.cs  |   6 ++--
 Software/Visual_Studio/Tango.BL/LiquidVolume.cs    |  12 ++++++-
 .../Tango.Emulations/Emulators/MachineEmulator.cs  |   2 +-
 .../Tango.Integration/Operation/MachineOperator.cs |   9 +++++-
 10 files changed, 91 insertions(+), 13 deletions(-)

(limited to 'Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views')

diff --git a/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/ViewModels/MainViewVM.cs b/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/ViewModels/MainViewVM.cs
index c9483b9a2..fec02529b 100644
--- a/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/ViewModels/MainViewVM.cs
+++ b/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/ViewModels/MainViewVM.cs
@@ -1034,6 +1034,11 @@ namespace Tango.MachineStudio.Developer.ViewModels
         {
             var percent = (e.Progress / e.Total * 100d);
 
+            if (_preparingTaskItem != null)
+            {
+                _preparingTaskItem.Message = $"Preparing job for printing {(e.Progress / e.Total * 100d).ToString("0.0")}%...";
+            }
+
             if (_preparingTaskItem == null && percent == 0)
             {
                 _preparingTaskItem = _notification.PushTaskItem("Preparing job for printing...");
@@ -1043,13 +1048,6 @@ namespace Tango.MachineStudio.Developer.ViewModels
                 _preparingTaskItem.Pop();
                 _preparingTaskItem = null;
             }
-            else
-            {
-                if (_preparingTaskItem != null)
-                {
-                    _preparingTaskItem.Message = $"Preparing job for printing {(e.Progress / e.Total * 100d).ToString("0.0")}%...";
-                }
-            }
         }
 
         private void MachineOperator_ResumingJob(object sender, ResumingJobEventArgs e)
diff --git a/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/JobView.xaml b/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/JobView.xaml
index 3bda86036..e1bbad6a7 100644
--- a/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/JobView.xaml
+++ b/Software/Visual_Studio/MachineStudio/Modules/Tango.MachineStudio.Developer/Views/JobView.xaml
@@ -1179,6 +1179,41 @@
                                                                                                                             </DataGridTemplateColumn.CellTemplate>
                                                                                                                         </DataGridTemplateColumn>
                                                                                                                         <DataGridTemplateColumn Header="PULSE / SEC">
+                                                                                                                            <DataGridTemplateColumn.CellTemplate>
+                                                                                                                                <DataTemplate>
+                                                                                                                                    <Label VerticalAlignment="Center">
+                                                                                                                                        <Label.Style>
+                                                                                                                                            <Style TargetType="Label">
+                                                                                                                                                <Setter Property="Content">
+                                                                                                                                                    <Setter.Value>
+                                                                                                                                                        <TextBlock>
+                                                                                                                                                 <Run Text="{Binding PulsePerSecondFull,Mode=OneWay,StringFormat='0.0'}"></Run>
+                                                                                                                                                 <Run Text="(pulse)" FontSize="9" Foreground="{StaticResource GrayBrush250}"></Run>
+                                                                                                                                                        </TextBlock>
+                                                                                                                                                    </Setter.Value>
+                                                                                                                                                </Setter>
+                                                                                                                                                <Style.Triggers>
+                                                                                                                                                    <DataTrigger Binding="{Binding DispenserStepDivision}" Value="{x:Static dispensing:DispenserStepDivisions.Auto}">
+                                                                                                                                                        <Setter Property="Content" Value="Auto"></Setter>
+                                                                                                                                                    </DataTrigger>
+                                                                                                                                                    <DataTrigger Binding="{Binding DispenserStepDivision,Converter={StaticResource IsNotConverter},ConverterParameter={x:Static dispensing:DispenserStepDivisions.Auto}}" Value="True">
+                                                                                                                                                        <Setter Property="Content">
+                                                                                                                                                            <Setter.Value>
+                                                                                                                                                                <TextBlock>
+                                                                                                                                                 <Run Text="{Binding PulsePerSecondFull,Mode=OneWay,StringFormat='0.0'}"></Run>
+                                                                                                                                                 <Run Text="(pulse)" FontSize="9" Foreground="{StaticResource GrayBrush250}"></Run>
+                                                                                                                                                                </TextBlock>
+                                                                                                                                                            </Setter.Value>
+                                                                                                                                                        </Setter>
+                                                                                                                                                    </DataTrigger>
+                                                                                                                                                </Style.Triggers>
+                                                                                                                                            </Style>
+                                                                                                                                        </Label.Style>
+                                                                                                                                    </Label>
+                                                                                                                                </DataTemplate>
+                                                                                                                            </DataGridTemplateColumn.CellTemplate>
+                                                                                                                        </DataGridTemplateColumn>
+                                                                                                                        <DataGridTemplateColumn Header="PULSE / SEC (full step)">
                                                                                                                             <DataGridTemplateColumn.CellTemplate>
                                                                                                                                 <DataTemplate>
                                                                                                                                     <Label VerticalAlignment="Center">
diff --git a/Software/Visual_Studio/Resources/Twine Software Items (version 1).xlsb.xlsx b/Software/Visual_Studio/Resources/Twine Software Items (version 1).xlsb.xlsx
index 3a107258a..221518a5c 100644
Binary files a/Software/Visual_Studio/Resources/Twine Software Items (version 1).xlsb.xlsx and b/Software/Visual_Studio/Resources/Twine Software Items (version 1).xlsb.xlsx differ
diff --git a/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcBase.cs b/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcBase.cs
index e0f16d4d4..dcca5817c 100644
--- a/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcBase.cs
+++ b/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcBase.cs
@@ -56,6 +56,16 @@ namespace Tango.BL.Dispensing
             return CalculateNanoliterPerSecond(liquidVolume) / liquidVolume.NanoliterPerStep / (double)liquidVolume.DispenserStepDivision;
         }
 
+        /// <summary>
+        /// Calculates the required full pulses per second.
+        /// </summary>
+        /// <param name="liquidVolume">The liquid volume.</param>
+        /// <returns></returns>
+        public double CalculatePulsePerSecondFull(LiquidVolume liquidVolume)
+        {
+            return CalculateNanoliterPerSecond(liquidVolume) / liquidVolume.NanoliterPerStep;
+        }
+
         /// <summary>
         /// Coerces the specified liquid volume.
         /// </summary>
diff --git a/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcService.cs b/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcService.cs
index a41eb1040..3dd38fb10 100644
--- a/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcService.cs
+++ b/Software/Visual_Studio/Tango.BL/Dispensing/DispensingCalcService.cs
@@ -44,6 +44,17 @@ namespace Tango.BL.Dispensing
             return formula.CalculatePulsePerSecond(liquidVolume);
         }
 
+        /// <summary>
+        /// Calculates the full pulse per second.
+        /// </summary>
+        /// <param name="liquidVolume">The liquid volume.</param>
+        /// <returns></returns>
+        public static double CalculatePulsePerSecondFull(LiquidVolume liquidVolume)
+        {
+            IDispensingCalc formula = DispensingCalcResolver.Resolve(liquidVolume);
+            return formula.CalculatePulsePerSecondFull(liquidVolume);
+        }
+
         /// <summary>
         /// Coerces the volume.
         /// </summary>
diff --git a/Software/Visual_Studio/Tango.BL/Dispensing/IDispensingCalc.cs b/Software/Visual_Studio/Tango.BL/Dispensing/IDispensingCalc.cs
index 7c5928bf6..7ec715a88 100644
--- a/Software/Visual_Studio/Tango.BL/Dispensing/IDispensingCalc.cs
+++ b/Software/Visual_Studio/Tango.BL/Dispensing/IDispensingCalc.cs
@@ -28,6 +28,13 @@ namespace Tango.BL.Dispensing
         /// <returns></returns>
         double CalculatePulsePerSecond(LiquidVolume liquidVolume);
 
+        /// <summary>
+        /// Calculates the required full pulses per second.
+        /// </summary>
+        /// <param name="liquidVolume">The liquid volume.</param>
+        /// <returns></returns>
+        double CalculatePulsePerSecondFull(LiquidVolume liquidVolume);
+
         /// <summary>
         /// Coerces the specified liquid volume.
         /// </summary>
diff --git a/Software/Visual_Studio/Tango.BL/Dispensing/TransparentLiquidDispensingCalc.cs b/Software/Visual_Studio/Tango.BL/Dispensing/TransparentLiquidDispensingCalc.cs
index 15e9b69d9..40a716c13 100644
--- a/Software/Visual_Studio/Tango.BL/Dispensing/TransparentLiquidDispensingCalc.cs
+++ b/Software/Visual_Studio/Tango.BL/Dispensing/TransparentLiquidDispensingCalc.cs
@@ -45,9 +45,9 @@ namespace Tango.BL.Dispensing
         {
             if (liquidVolume.ProcessParametersTable != null)
             {
-                double nlPcmSum = liquidVolume.BrushStop.LiquidVolumes.Where(x => (IdsPackFormulas)x.IdsPack.IdsPackFormula.Code == IdsPackFormulas.StandardColor).Sum(x => x.NanoliterPerCentimeter);
-                double minInkUptake = liquidVolume.ProcessParametersTable.MinInkUptake;
-                double volume = ((liquidVolume.LiquidMaxNanoliterPerCentimeter - nlPcmSum) / liquidVolume.LiquidMaxNanoliterPerCentimeter) * 100d;
+                //double nlPcmSum = liquidVolume.BrushStop.LiquidVolumes.Where(x => (IdsPackFormulas)x.IdsPack.IdsPackFormula.Code == IdsPackFormulas.StandardColor).Sum(x => x.NanoliterPerCentimeter);
+                //double minInkUptake = liquidVolume.ProcessParametersTable.MinInkUptake;
+                //double volume = ((liquidVolume.LiquidMaxNanoliterPerCentimeter - nlPcmSum) / liquidVolume.LiquidMaxNanoliterPerCentimeter) * 100d;
                 return Math.Max(100d - liquidVolume.BrushStop.LiquidVolumes.Where(x => (IdsPackFormulas)x.IdsPack.IdsPackFormula.Code == IdsPackFormulas.StandardColor).Sum(x => x.Volume), 0);
             }
             else
diff --git a/Software/Visual_Studio/Tango.BL/LiquidVolume.cs b/Software/Visual_Studio/Tango.BL/LiquidVolume.cs
index 69499905a..723356ef6 100644
--- a/Software/Visual_Studio/Tango.BL/LiquidVolume.cs
+++ b/Software/Visual_Studio/Tango.BL/LiquidVolume.cs
@@ -70,7 +70,7 @@ namespace Tango.BL
         public DispenserStepDivisions DispenserStepDivision
         {
             get { return (DispenserStepDivisions)BrushStop.GetDispensingDivision(IdsPack.PackIndex); }
-            set { BrushStop.SetDispensingDivision(IdsPack.PackIndex, (int)value); RaisePropertyChangedAuto(); RaisePropertyChanged(nameof(PulsePerSecond)); RaisePropertyChanged(nameof(NanoliterPerStep)); }
+            set { BrushStop.SetDispensingDivision(IdsPack.PackIndex, (int)value); RaisePropertyChangedAuto(); RaisePropertyChanged(nameof(PulsePerSecond)); RaisePropertyChanged(nameof(NanoliterPerStep)); RaisePropertyChanged(nameof(PulsePerSecondFull)); }
         }
 
         public void Invalidate()
@@ -96,6 +96,7 @@ namespace Tango.BL
                 RaisePropertyChanged(nameof(LiquidMaxNanoliterPerCentimeter));
                 RaisePropertyChanged(nameof(NanoliterPerSecond));
                 RaisePropertyChanged(nameof(PulsePerSecond));
+                RaisePropertyChanged(nameof(PulsePerSecondFull));
                 RaisePropertyChanged(nameof(NanoliterPerCentimeter));
                 RaisePropertyChanged(nameof(Volume));
                 RaisePropertyChanged(nameof(NanoliterPerStep));
@@ -177,6 +178,15 @@ namespace Tango.BL
             }
         }
 
+        [JsonIgnore]
+        public double PulsePerSecondFull
+        {
+            get
+            {
+                return DispensingCalcService.CalculatePulsePerSecondFull(this);
+            }
+        }
+
         [JsonIgnore]
         public double NanoliterPerStep
         {
diff --git a/Software/Visual_Studio/Tango.Emulations/Emulators/MachineEmulator.cs b/Software/Visual_Studio/Tango.Emulations/Emulators/MachineEmulator.cs
index ad3b242f4..74eb3cab1 100644
--- a/Software/Visual_Studio/Tango.Emulations/Emulators/MachineEmulator.cs
+++ b/Software/Visual_Studio/Tango.Emulations/Emulators/MachineEmulator.cs
@@ -660,7 +660,7 @@ namespace Tango.Emulations.Emulators
             double progress = 0;
             _cancelJob = false;
             bool message_sent = false;
-            double length = job.Segments.Sum(x => x.Length) * (Math.Max(job.NumberOfUnits, 1));
+            double length = job.Length;
 
             Task.Factory.StartNew(() =>
             {
diff --git a/Software/Visual_Studio/Tango.Integration/Operation/MachineOperator.cs b/Software/Visual_Studio/Tango.Integration/Operation/MachineOperator.cs
index 6963b90d4..ea1b0a0e3 100644
--- a/Software/Visual_Studio/Tango.Integration/Operation/MachineOperator.cs
+++ b/Software/Visual_Studio/Tango.Integration/Operation/MachineOperator.cs
@@ -1272,6 +1272,13 @@ namespace Tango.Integration.Operation
                     PreparingJobProgress?.Invoke(this, e);
                 });
                 LogManager.Log($"Gradient generated.");
+
+                PreparingJobProgress?.Invoke(this, new PreparingJobProgressEventArgs()
+                {
+                    Job = job,
+                    Total = job.Segments.Sum(x => x.Length),
+                    Progress = job.Segments.Sum(x => x.Length),
+                });
             }
 
             foreach (var stop in stops)
@@ -1784,7 +1791,7 @@ namespace Tango.Integration.Operation
 
                 if (JobUnitsMethod == JobUnitsMethods.Device)
                 {
-                    ticket.NumberOfUnits = (uint)job.NumberOfUnits;
+                    ticket.NumberOfUnits = (uint)Math.Max(job.NumberOfUnits, 1);
                 }
 
                 ticket.Spool = new JobSpool();
-- 
cgit v1.3.1